Skip to content

Conversation

@willholley
Copy link
Contributor

Droppable: tolerance, pointer - bug when pointer outside draggable.

Updated the patch supplied on the ticket to the current master.

@mikesherov
Copy link
Member

@willholley, thanks for contributing! If you haven't already, please sign our CLA: http://contribute.jquery.org/CLA/

Also, please remove the droppable_tickets.js file and add the tests to the appropriate existing test files for droppable. After that, I can review this. Glad to see a healthy set of tests added :-)

@willholley
Copy link
Contributor Author

Thanks for the feedback - I've signed the CLA and updated the patch. The test now lives in droppable_events.js.

…er outside draggable

Credit for this patch should go to Kevin Wells. This commit updates his previous patch to work against the current master.
@bhiggins
Copy link
Contributor

Tested and works against v1.10.3. What's the next step on this request?

@indiefan
Copy link

Is this fix going to be integrated? It seems like a significant problem.

@mikesherov
Copy link
Member

I'll be landing this pull request tomorrow once I get near a computer. There's lots of whitespace to clean up.

@multiwebinc
Copy link

@mikesherov Still working on this? Are there any workarounds in the meantime before it gets included?

@mikesherov
Copy link
Member

@multiwebinc. Sorry I completely forgot about this PR. I will be landing it soon. For real this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants